-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reasons to unsub modal #24109
Conversation
📸 UI snapshots have been updated4 snapshot changes in total. 0 added, 4 modified, 0 deleted:
Triggered by this commit. |
Size Change: -152 B (-0.01%) Total Size: 1.07 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, the items of this list just don't look selectable. Checkboxes are probably the best pattern to use in here – they are clearly interactive and clearly multi-select
Cool I can make that change. |
📸 UI snapshots have been updated5 snapshot changes in total. 0 added, 5 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
love it
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few suggestions for increased UI clarity that are nice-to-haves – overall:
'Found a better alternative', | ||
'Poor customer support', | ||
'Too difficult to use', | ||
'Not enough hedgehogs', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LOL
</Link> | ||
</p> | ||
</LemonBanner> | ||
<p> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's some extra-large margin here due to p
's implicit margin-bottom:
<p> | |
<p className="mb-0"> |
(this is important so that the modal doesn't require scrolling)
Changes
We want to know more about why people are unsubscribing. This will add 5 options, and users can select multiples on top of an open text box. The hope is that more users will fill it out.
Looking for feedback on the UI:
Note: I'm seeing an issue locally where survey events are being triggered a bunch of times; I'm not sure if it's just a local issue but it's unrelated to my PR.
Another note: We've also seen a spike in survey sent/dismissed events this week: https://us.posthog.com/project/2/insights/wDZyeL6N
We will need to update the Slack hook to account for this, I need to figure out where that is configured.
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
No
How did you test this code?
Snapshots will get updated